<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107192/">http://git.reviewboard.kde.org/r/107192/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think is already better than the current one that has some serious issues, so it should go in</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107192/diff/2/?file=94337#file94337line110" style="color: black; font-weight: bold; text-decoration: underline;">applets/comic/comic.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">102</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="ew"> </span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">93</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">whitespace</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107192/diff/2/?file=94337#file94337line361" style="color: black; font-weight: bold; text-decoration: underline;">applets/comic/comic.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ComicApplet::dataUpdated( const QString &source, const Plasma::DataEngine::Data &data )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">348</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//disconnect if there is either no error, or an error that can not be fixed automatically<span class="ew"> </span></span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">229</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//disconnect if there is either no error, or an error that can not be fixed automatically<span class="ew"> </span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">whitespace</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107192/diff/2/?file=94350#file94350line149" style="color: black; font-weight: bold; text-decoration: underline;">applets/comic/package/contents/ui/main.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">149</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> if ( showComicAuthor &&<span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">whitespace</pre>
</div>
<br />
<p>- Marco</p>
<br />
<p>On November 8th, 2012, 12:47 p.m., Reza Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Reza Shah.</div>
<p style="color: grey;"><i>Updated Nov. 8, 2012, 12:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is an attempt to port some part of comic plasmoid to QML.
Most of the ported part are related to UI.
The comic fetching logic are still in C++.
In this patch, some features which related to changing applet size are removed.
known problem:
- tooltip to display additional text(the code is exist but still have problem).
You can also try from rshah/comicqml branch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested the applet from my branch with other environment from master, seems working fine.
There might be some missing features.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/comic/CMakeLists.txt <span style="color: grey">(91fa29f)</span></li>
<li>applets/comic/activecomicmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/activecomicmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/appearanceSettings.ui <span style="color: grey">(a153bf2)</span></li>
<li>applets/comic/arrowwidget.h <span style="color: grey">(64b1b36)</span></li>
<li>applets/comic/arrowwidget.cpp <span style="color: grey">(72d48ed)</span></li>
<li>applets/comic/buttonbar.h <span style="color: grey">(d4020bb)</span></li>
<li>applets/comic/buttonbar.cpp <span style="color: grey">(bb4dbef)</span></li>
<li>applets/comic/comic.h <span style="color: grey">(f5919df)</span></li>
<li>applets/comic/comic.cpp <span style="color: grey">(3753eac)</span></li>
<li>applets/comic/comicwidgets.h <span style="color: grey">(4320c58)</span></li>
<li>applets/comic/configwidget.h <span style="color: grey">(e9d63c8)</span></li>
<li>applets/comic/configwidget.cpp <span style="color: grey">(baddd45)</span></li>
<li>applets/comic/fullviewwidget.h <span style="color: grey">(c0a1aff)</span></li>
<li>applets/comic/fullviewwidget.cpp <span style="color: grey">(fc78ba6)</span></li>
<li>applets/comic/imagewidget.h <span style="color: grey">(0825cfc)</span></li>
<li>applets/comic/imagewidget.cpp <span style="color: grey">(9d36034)</span></li>
<li>applets/comic/package/contents/ui/ButtonBar.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/package/contents/ui/ComicBottomInfo.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/package/contents/ui/ComicCentralView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/package/contents/ui/FullViewWidget.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/package/contents/ui/ImageWidget.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107192/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>