<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107261/">http://git.reviewboard.kde.org/r/107261/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 21d139b7382256fdd62933f61987903779f63010 by Aleix Pol to branch KDE/4.10.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 9th, 2012, 1:27 a.m., Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2012, 1:27 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Right now, every QML plasmoid can provide a number of properties (6, actually) to specify some size hints (maximum, minimum and preferred).
If you don't provide those properties you get many warnings because of the missing changed connections. This patch removes such warnings by making sure the property is present before connecting and querying the property at all.
I'd suggest that in case we want notifications for the lack of those properties, this should be in the plasmoidviewer or such. Today I was trying to debug an issue while loading the qml wallpapers when loading plasma-desktop and I was flooded by those.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I ran org.kde.graphsplasmoid before patching and I got many warnings. After patching I didn't get those.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/widgets/declarativewidget.cpp <span style="color: grey">(3176073)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107261/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>