<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107262/">http://git.reviewboard.kde.org/r/107262/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 9th, 2012, 10:52 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nice work :) it's really coming into a very good shape ...</pre>
</blockquote>
<p>On November 9th, 2012, 11:22 a.m., <b>Dmitry Ashkadov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But there is one problem: property id of Plasma::Applet isn't a constant for now, so, there are warnings in stdout.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">.. already fixed in kdelibs, and it is only a warning so nothing to worry about.</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On November 9th, 2012, 9:59 a.m., Dmitry Ashkadov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Dmitry Ashkadov.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2012, 9:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Special class Plasmoid no more need, for QML code SystemTray::Applet is sufficient</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/systemtray/CMakeLists.txt <span style="color: grey">(78031fd)</span></li>
<li>plasma/generic/applets/systemtray/package/contents/ui/IconsList.qml <span style="color: grey">(6d35beb)</span></li>
<li>plasma/generic/applets/systemtray/package/contents/ui/main.qml <span style="color: grey">(d942fba)</span></li>
<li>plasma/generic/applets/systemtray/ui/applet.h <span style="color: grey">(30c6214)</span></li>
<li>plasma/generic/applets/systemtray/ui/applet.cpp <span style="color: grey">(ecac20c)</span></li>
<li>plasma/generic/applets/systemtray/ui/plasmoid.h <span style="color: grey">(d0bbf61)</span></li>
<li>plasma/generic/applets/systemtray/ui/plasmoid.cpp <span style="color: grey">(1491595)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107262/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>