<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107232/">http://git.reviewboard.kde.org/r/107232/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3f5d7444f8a3373befdceffca79744c82899d4e1 by Sebastian Kügler to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 7th, 2012, 2:40 p.m., Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2012, 2:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ToolBox bindings for declarative containments
This adds the necessary bits, actions handling, showing / hiding of toolbox and a hooks for config interface and add widgets.
The interesting bits:
Toolbox separate on the scene
For declarative containments, we add a declarativewidget on top of the view which loads the "org.kde.toolbox" package. The toolbox can differ per platform, layout of toolbox and containment can not "leak" into each other.
ToolBox import
The most important and interesting bit is the list of actions the ToolBox exposes, it's collected from corona, containment. The latter is actually problematic, since we don't get access to the actions internally provided by Containment (ContainmentPrivate::addDefaultActions). Containment::setToolBox(AbstractToolBox) being protected, we cannot register our declarative ToolBoxProxy implementation to the containment, so we have to wire up settings and addwidgets separately. Sorting of the actions is "random", and expected to be done by the QML toolbox implementation, based on objectName strings.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using this with QML Desktop Containment, works as advertised above.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/scriptengines/javascript/CMakeLists.txt <span style="color: grey">(fe06582)</span></li>
<li>plasma/scriptengines/javascript/declarative/toolboxproxy.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/scriptengines/javascript/declarative/toolboxproxy.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/scriptengines/javascript/plasmoid/appletinterface.h <span style="color: grey">(6fc2d74)</span></li>
<li>plasma/scriptengines/javascript/plasmoid/appletinterface.cpp <span style="color: grey">(ed5c8ae)</span></li>
<li>plasma/scriptengines/javascript/plasmoid/declarativeappletscript.h <span style="color: grey">(57689ba)</span></li>
<li>plasma/scriptengines/javascript/plasmoid/declarativeappletscript.cpp <span style="color: grey">(4caceb0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107232/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>