<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107001/">http://git.reviewboard.kde.org/r/107001/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 6th, 2012, 5:53 p.m., <b>Daker Pinheiro</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You should move the javascript functions to a separated Javascript file.
It would keep the plasmoid modularized.
A repeater could be used for creating the digits button.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>You should move the javascript functions to a separated Javascript file.
See above response to Mark.</pre>
<br />
<p>- Romário</p>
<br />
<p>On November 6th, 2012, 2:54 a.m., Romário Rios wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Romário Rios.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2012, 2:54 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested as both applet and popupapplet, with the Air theme and the Oxygen theme. It seems to work fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/calculator/CMakeLists.txt <span style="color: grey">(732145c)</span></li>
<li>applets/calculator/calculator.h <span style="color: grey">(f7339be)</span></li>
<li>applets/calculator/calculator.cpp <span style="color: grey">(6bc3ddc)</span></li>
<li>applets/calculator/package/contents/ui/calculator.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/calculator/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/calculator/plasma-applet-calculator.desktop <span style="color: grey">(0760729)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107001/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>