<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106999/">http://git.reviewboard.kde.org/r/106999/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit fe5032ec7d5d85caca79983ad7fd392c39cff58a by Diego Casella to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On October 22nd, 2012, 11:01 p.m., Diego Casella wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Diego Casella.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2012, 11:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When you open the Activity Manager, and click the "Configure" button, the stacked config page displays a misplaced iconButton (see figure on the left).
That's because, in ActivityDelegate, the implicitHeight of the component is forced to 20.
Funny observation: this weird behavior shows up only when Activity Manager is displayed horizontally ... Vertically, everything is just fine.
Anyway the "patch" is just an one-liner so it should be OK, I suppose.
The fixed component is shown in the screenshot on the right.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works perfectly, both with horizontal and vertical placement (see shots below).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/activitymanager/package/contents/ui/ActivityDelegate.qml <span style="color: grey">(4af21e7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106999/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106999/s/790/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/22/plasma_activitymanager_400x100.png" style="border: 1px black solid;" alt="Activity Manager, before" /></a>
<a href="http://git.reviewboard.kde.org/r/106999/s/791/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/22/plasma_activitymanager1_400x100.png" style="border: 1px black solid;" alt="Activity Manager, after" /></a>
<a href="http://git.reviewboard.kde.org/r/106999/s/792/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/22/plasma_activitymanager_androbit_400x100.png" style="border: 1px black solid;" alt="Activity Manager, Androbit theme" /></a>
<a href="http://git.reviewboard.kde.org/r/106999/s/793/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/22/plasma_activitymanager_aya_400x100.png" style="border: 1px black solid;" alt="Activity Manager, Aya theme" /></a>
<a href="http://git.reviewboard.kde.org/r/106999/s/794/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/22/plasma_activitymanager_produkt_400x100.png" style="border: 1px black solid;" alt="Activity Manager, Produkt theme" /></a>
<a href="http://git.reviewboard.kde.org/r/106999/s/795/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/22/plasma_activitymanager_slimglow_400x100.png" style="border: 1px black solid;" alt="Activity Manager, Slim Glow theme" /></a>
<a href="http://git.reviewboard.kde.org/r/106999/s/796/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/22/plasma_activitymanager_tibanna_400x100.png" style="border: 1px black solid;" alt="Activity Manager, Tibanna theme" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>