<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106965/">http://git.reviewboard.kde.org/r/106965/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 20th, 2012, 11:18 a.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106965/diff/1/?file=91357#file91357line1" style="color: black; font-weight: bold; text-decoration: underline;">plasma/generic/applets/systemtray/ui/wheelarea.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm">/***********************************************************************************************************************</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this implementation is not necessary, a wheelevent was added in org.kde.qtextracomponents in MouseEventListener
the TODO of replacing this in qt5 stays, but is a c++ file less
see http://api.kde.org/4.x-api/kde-runtime-apidocs/plasma/html/classMouseEventListener.html wheelEvent</pre>
</blockquote>
<p>On October 22nd, 2012, 9:30 a.m., <b>Dmitry Ashkadov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, I have replaced WheelArea with MouseEventListener. But I have some questions:
1. Does the workflow (http://www.reviewboard.org/docs/manual/1.6/users/getting-started/workflow/) oblige me to update full diff? It may difficalt to find changed in full diff.
2. Who have to click on "Fixed"/"Drop" buttons? On the one hand, who requires changes should check changes and apply them or reject, on the second hand, these buttons may notify review about fixed issue.
3. Some MouseEventListener's signals give objects named wheel or mouse, but mouse.button/wheel.button have type QVariant, so it's impossible to use switch (mouse.button) { case Qt.LeftButton: ... }. At the same time Qt's MouseArea has different behaviour — switch (mouse.button) { case Qt.RightButton: ... } works</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) yeah, sometimes is a bit of a mess.. a new diff from master should work tough (if is not possible to make a clean diff, just state that the branch has been updated accordingly)
2) for the issues on those comments, you can just mark them as fixed them after you made that change, to signal that.
3) that's weird, the mouse event object just exports buttons as Qt::MouseButton enum, like upstream mousearea does, something strange happening at binding level...
anyways, mouseeventlistener should be used just when is really needed something that mousearea can't provide, that at the moment is:
* wheel
* screen coordinates for events
* the main usecase of the class, litening to events that are happening to its children, but without interfering withthem in any way
</pre>
<br />
<p>- Marco</p>
<br />
<p>On October 22nd, 2012, 9:19 a.m., Dmitry Ashkadov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Dmitry Ashkadov.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2012, 9:19 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implementation of GUI part of System tray in QML. All code accessible from specified branch of kde-workspace </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/systemtray/CMakeLists.txt <span style="color: grey">(d3ce33b)</span></li>
<li>plasma/generic/applets/systemtray/TODO <span style="color: grey">(257fbe4)</span></li>
<li>plasma/generic/applets/systemtray/config.h.in <span style="color: grey">(aac3113)</span></li>
<li>plasma/generic/applets/systemtray/core/task.h <span style="color: grey">(31d5949)</span></li>
<li>plasma/generic/applets/systemtray/core/task.cpp <span style="color: grey">(55c9a1a)</span></li>
<li>plasma/generic/applets/systemtray/package/contents/ui/ArrowArea.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/package/contents/ui/IconsGrid.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/package/contents/ui/IconsList.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/package/contents/ui/IconsList.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/package/contents/ui/TasksSet.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/package/contents/ui/TrayIcon.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/package/contents/ui/main.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.h <span style="color: grey">(aa6050e)</span></li>
<li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.cpp <span style="color: grey">(f4e8424)</span></li>
<li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h <span style="color: grey">(2847b25)</span></li>
<li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp <span style="color: grey">(d4cb309)</span></li>
<li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraywidget.h <span style="color: grey">(0c6daf0)</span></li>
<li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraywidget.cpp <span style="color: grey">(33cf0b1)</span></li>
<li>plasma/generic/applets/systemtray/protocols/fdo/fdotask.h <span style="color: grey">(4cb5368)</span></li>
<li>plasma/generic/applets/systemtray/protocols/fdo/fdotask.cpp <span style="color: grey">(69cd625)</span></li>
<li>plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.h <span style="color: grey">(3e8d120)</span></li>
<li>plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.cpp <span style="color: grey">(8c1ebba)</span></li>
<li>plasma/generic/applets/systemtray/ui/applet.h <span style="color: grey">(d6cc509)</span></li>
<li>plasma/generic/applets/systemtray/ui/applet.cpp <span style="color: grey">(f3c6d9a)</span></li>
<li>plasma/generic/applets/systemtray/ui/compactlayout.h <span style="color: grey">(c330cee)</span></li>
<li>plasma/generic/applets/systemtray/ui/compactlayout.cpp <span style="color: grey">(e8d02ff)</span></li>
<li>plasma/generic/applets/systemtray/ui/dialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/ui/dialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/ui/mouseredirectarea.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/ui/mouseredirectarea.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/ui/plasmoid.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/ui/plasmoid.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/ui/taskarea.h <span style="color: grey">(0e73ead)</span></li>
<li>plasma/generic/applets/systemtray/ui/taskarea.cpp <span style="color: grey">(4c2d120)</span></li>
<li>plasma/generic/applets/systemtray/ui/taskarea_p.h <span style="color: grey">(fc93661)</span></li>
<li>plasma/generic/applets/systemtray/ui/taskspool.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/ui/taskspool.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/ui/uitask.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/ui/uitask.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/ui/widgetitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/systemtray/ui/widgetitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106965/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106965/s/788/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/20/systemtray_new_400x100.png" style="border: 1px black solid;" alt="Example" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>