<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106907/">http://git.reviewboard.kde.org/r/106907/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i tried it on a wetab with some 12megapixels photos.
it's way better than some time ago (ie Qt 4.8.0 times).
i am not sure if a check that the source size is very big could still make sense, perhaps still reducing sourcesize if exceeds something like 20k pixels or something like that
</pre>
<br />
<p>- Marco</p>
<br />
<p>On October 16th, 2012, 6:49 a.m., Ruediger Gad wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Ruediger Gad.</div>
<p style="color: grey;"><i>Updated Oct. 16, 2012, 6:49 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the current state of the image viewer app zoom gestures work.
However, on load the image resolution is set to match the size of the image viewer.
When images are magnified this seems not to be adapted correctly.
Thus, instead of really zooming into an image only larger pixels are displayed.
This patch is an attempt to fix this and allow proper zooming.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested this on Archos G9 turbo (2x1.5 GHz, 1 GB RAM).
For testing I used pictures with resolutions up to 11700x1200 pixels.
Load times with this patch applied seemed not to differ from load times without this patch.
In case of very large pictures (see above) the load time was about 0.5 seconds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applications/filebrowser/imageviewerpart/contents/ui/FullScreenDelegate.qml <span style="color: grey">(ba3aea8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106907/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>