<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106797/">http://git.reviewboard.kde.org/r/106797/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i like the change.
it keeps the same resulting pixel height and that's important (most widgets end up having the same->easy vertical alignment)
only thing that doesn't convince me too much is that while the final height is still m height * 1.6, isn'tindicated directly anymore, so a bit easier to lose (ideally this should be a constant somewhere)</pre>
<br />
<p>- Marco</p>
<br />
<p>On October 11th, 2012, 3:09 p.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Oct. 11, 2012, 3:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix padding to the left and right of text in a textField
Text was already fontSize*1.6 meaning there was a 0.3 textHeight padding on the top and bottom. Padding on the left and right was completely missing. It's fairly typical to make the padding on the top and bottom match left and right.
If this patch gets accepted I'll make the same change in TextArea.
Before and after shots show it best.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/plasmacomponents/qml/TextField.qml <span style="color: grey">(201b61b958a04b621ccb20abbc5f1d7cfeea6798)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106797/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106797/s/766/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/11/textfield_before_400x100.png" style="border: 1px black solid;" alt="Before" /></a>
<a href="http://git.reviewboard.kde.org/r/106797/s/767/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/11/textfield_after_400x100.png" style="border: 1px black solid;" alt="After" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>