<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106448/">http://git.reviewboard.kde.org/r/106448/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On October 5th, 2012, 9:37 a.m., <b>Marco Martin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">any updates on this?
what are the major blocker still remaining for a merge?</pre>
 </blockquote>




 <p>On October 5th, 2012, 1:26 p.m., <b>Greg T</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">well, to summarize it:
- classic menu broken
- some minor functionality missing
- martin didn't tested it?

I think we can address those points also post-review.</pre>
 </blockquote>





 <p>On October 5th, 2012, 1:52 p.m., <b>Martin Gräßlin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How badly is the classic menu broken? I assume it does not compile any more, right?

My personal opinion would be to pass it to the community, kind of "The KDE Classic Menu Needs You!" (Uncle Sam image)</pre>
 </blockquote>





 <p>On October 5th, 2012, 1:56 p.m., <b>Marco Martin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">and is perfectly fine for the classic menu to stay c++ btw, since there is (almost) no qgraphicsview involved</pre>
 </blockquote>








</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yeah, it doesn't compile. Though I didn't try it really hard.

But great idea! Can you post it on your famous blog? I'm sure there will be a lot of resonance. I also think we can flag that as a junior job.</pre>
<br />








<p>- Greg</p>


<br />
<p>On September 20th, 2012, 4:10 p.m., Greg T wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Plasma and Martin Gräßlin.</div>
<div>By Greg T.</div>


<p style="color: grey;"><i>Updated Sept. 20, 2012, 4:10 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it's time now to get the new kickoff into master so we can polish it for KDE 4.10. the qml plasmoid is still using the old model code (though slightly adjusted). This could cause issues for the c++ menu launcher "simpleapplet"...I'm not using it but actually it doesn't even compile. Probably would be better to port it to qml as well...opinions?

The qml code resides in the package dir. It's a pure qml widget with c++ model extensions...obviously :)

Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++

I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users?

</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksplash/ksplashqml/SplashWindow.cpp <span style="color: grey">(94e6dedfddcac20516686a7a3b30651d48bc26e7)</span></li>

 <li>plasma/desktop/applets/kickoff/CMakeLists.txt <span style="color: grey">(4b0d32a9d0e7d46d05c4efdef9dc39fd653cc2f9)</span></li>

 <li>plasma/desktop/applets/kickoff/Messages.sh <span style="color: grey">(b1fa03bcfd6254de7697a674a37919724a0a0965)</span></li>

 <li>plasma/desktop/applets/kickoff/core/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/core/applicationmodel.h <span style="color: grey">(f0f8872255956321292151cdd82326cdf88c5508)</span></li>

 <li>plasma/desktop/applets/kickoff/core/applicationmodel.cpp <span style="color: grey">(74b2595ba67de1cdd2f93d3e9e7c2eebd68f6df2)</span></li>

 <li>plasma/desktop/applets/kickoff/core/favoritesmodel.h <span style="color: grey">(8ee3e9a9eb16780131d59b150b50641e5a03a34c)</span></li>

 <li>plasma/desktop/applets/kickoff/core/favoritesmodel.cpp <span style="color: grey">(14e35cdced82384f0cdf86caec9a4045bfaf2912)</span></li>

 <li>plasma/desktop/applets/kickoff/core/itemhandlers.h <span style="color: grey">(ec72cbe51b6e2da604ba6eba96f9e6f3f5935f67)</span></li>

 <li>plasma/desktop/applets/kickoff/core/itemhandlers.cpp <span style="color: grey">(4e83c37588af1ebab331082e2eaccb40a0f8155c)</span></li>

 <li>plasma/desktop/applets/kickoff/core/kickoffabstractmodel.cpp <span style="color: grey">(7e2e64d22e9e274ffe3d37fdd0ac2c33a622ea3a)</span></li>

 <li>plasma/desktop/applets/kickoff/core/kickoffmodel.cpp <span style="color: grey">(8149cac20ce8ab246d8f484ca7567fc6e32d548c)</span></li>

 <li>plasma/desktop/applets/kickoff/core/kickoffplugin.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/core/kickoffplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/core/kickoffproxymodel.cpp <span style="color: grey">(f92bca971e0f9fcb644cadab6aa39a3e36291c00)</span></li>

 <li>plasma/desktop/applets/kickoff/core/krunnermodel.h <span style="color: grey">(93a8b152a673eb6233727a82eefd70739ffc5a0f)</span></li>

 <li>plasma/desktop/applets/kickoff/core/krunnermodel.cpp <span style="color: grey">(452ebbe81311f8e3e95b5eda5fb9217344852d06)</span></li>

 <li>plasma/desktop/applets/kickoff/core/leavemodel.h <span style="color: grey">(0676fb9358bdfd5e3cffce7eb3a0ea5e4ff70989)</span></li>

 <li>plasma/desktop/applets/kickoff/core/leavemodel.cpp <span style="color: grey">(31467acc6654decb2800cf9a5acc398ccaaeccc7)</span></li>

 <li>plasma/desktop/applets/kickoff/core/models.h <span style="color: grey">(3332ba9608808b353c32d96c37b84ddd82aabddf)</span></li>

 <li>plasma/desktop/applets/kickoff/core/models.cpp <span style="color: grey">(c787df6e2f2c7c88ff97c64c7cd7640cce32365b)</span></li>

 <li>plasma/desktop/applets/kickoff/core/qmldir <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/core/recentapplications.h <span style="color: grey">(a0feddca1cebbeb556623216bcc6c5c30e13a2a4)</span></li>

 <li>plasma/desktop/applets/kickoff/core/recentapplications.cpp <span style="color: grey">(3e0538958564ae690e41791bdb5af76fa2ca9a8f)</span></li>

 <li>plasma/desktop/applets/kickoff/core/recentlyusedmodel.h <span style="color: grey">(841eb2b77aee778a85c76eafa61d38016f6ade58)</span></li>

 <li>plasma/desktop/applets/kickoff/core/recentlyusedmodel.cpp <span style="color: grey">(2762d6d63a7b0592a7e87cd99603cc7c418292c5)</span></li>

 <li>plasma/desktop/applets/kickoff/core/systemmodel.h <span style="color: grey">(b04a7871883edd5ea7281d9853ec9203ce019894)</span></li>

 <li>plasma/desktop/applets/kickoff/core/systemmodel.cpp <span style="color: grey">(cb9bf650bab36c6415d37db795e766b743d5e25d)</span></li>

 <li>plasma/desktop/applets/kickoff/core/urlitemlauncher.h <span style="color: grey">(26b638fc02f42505e29857b5c18736e6778a580e)</span></li>

 <li>plasma/desktop/applets/kickoff/core/urlitemlauncher.cpp <span style="color: grey">(75bbfb5a5c6df837e7e56de501156b2ca12ed6d7)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/Breadcrumb.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/KickoffButton.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/MainView.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/SearchView.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/config.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/packagekit.operations <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/packagekitengine.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/packagekitengine.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/packagekitjob.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/packagekitjob.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/packagekitservice.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/packagekitservice.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/plasma-dataengine-packagekit.desktop <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106448/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>