<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106665/">http://git.reviewboard.kde.org/r/106665/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 1st, 2012, 10:34 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i think this change is necessary and can go in. however, the model MUST then be fixed to at least show all non-created files described in the package as well otherwise things like creating new images or populating the default settings will be hard/impossible for the user and making that easy is plasmate's #1 purpose in life. :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> the model MUST then be fixed to at least show all non-created files described in the package
It will be fixed by then :)</pre>
<br />
<p>- Giorgos</p>
<br />
<p>On October 1st, 2012, 8:46 a.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated Oct. 1, 2012, 8:46 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Until now plasmate was creating all the Package::files() on the load of the project,
with this patch it will create only the Package::requiredFiles().
Also we **have** to s/Package::files()/Package::requiredFiles(), because right now
1. the Plasma themes are broken:
plasmate creates all the listing files of the theme package with QFile,so QSvgRenderer can't
open them, and if the user adds one more foo.svgz file, he will end up with 2 foo.svg files and
even if he deletes the corrupted one it will be recreated on the next load
2. plasmate forces the user to have a main.xml and a default-configrc, also even if the user deletes
those files, on the reload they will be recreated.
I haven't s/Package::dirs()/Package::RequiredDirs() because we don't have any ui element in order to
inform the user that the foo dir(for examples the images or the animations dir) exists, so he will have to
figure it out and create it manually and even if he does the dirs won't appear in the plasmate's package model.
The only drawback of this patch is that the user won't see anymore the description of the file but he will see their names.
I believe that for the moment we should add this patch and to fix the PackageModel issues after the beta.
P.S.: I replaced some deprecated methods.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>packagemodel.cpp <span style="color: grey">(d9cc35e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106665/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>