<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106519/">http://git.reviewboard.kde.org/r/106519/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit d6de898bee50f92307422852b9f20c78635db311 by Ralf Jung to branch KDE/4.9.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 21st, 2012, 3:57 p.m., Ralf Jung wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Ralf Jung.</div>
<p style="color: grey;"><i>Updated Sept. 21, 2012, 3:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is my attempt to fix redrawing the panel when the screen is resized. During my experiments, I added update() calls to all places I could think of, but none of them helped - it seems that even though the panel is redrawn, that content is not properly displayed. I am not sure whether this might actually be a bug in KWin: For example, I also saw parts of the panel content end up in the desktop background if compositing was disabled and the background was set to a solid black, opposed to an actual image. I don't have the knowledge to persuade that idea further though.
I found, however, a solution (or a work-around) to fix the panel bug. Is that acceptable?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Re-sized the screen a few times (using xrandr) to verify that the graphical glitches after a resize are gone.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=269635">269635</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/desktopcorona.h <span style="color: grey">(b65a926)</span></li>
<li>plasma/desktop/shell/desktopcorona.cpp <span style="color: grey">(ea58c2c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106519/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>