<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106490/">http://git.reviewboard.kde.org/r/106490/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On September 18th, 2012, 12:57 p.m., Alberto Villa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Alberto Villa.</div>
<p style="color: grey;"><i>Updated Sept. 18, 2012, 12:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The device notifier is using model["Free Space( Text)"] to show information which is not always available. As per Qt documentation, QML models need their roles defined at the beginning, thus, when the plasmoid is loaded with no accessible drives on the system, those two roles are not created (plasma/generic/dataengines/soliddevice/soliddeviceengine.cpp), and the plasmoid will always show "undefined" for its whole lifetime.
This behaviour isn't observed on Linux apparently, I guess because UDisks always reports some accessible (internal) drives. It might be the same on FreeBSD (which I run), but since my configuration is a bit weird (ZFS), I spotted the bug.
I reported the problem to Marco Martin and he blogged about it - http://www.notmart.org/index.php/BlaBla/Note_about_QML_plasmoids_and_dat - confirming my analysis.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With the patch applied, the plasmoid shows space information. The changes were confirmed by Marco Martin in his blog post.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml <span style="color: grey">(7ac95e7)</span></li>
<li>plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml <span style="color: grey">(bf07b10)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106490/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>