<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106272/">http://git.reviewboard.kde.org/r/106272/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 31st, 2012, 1:18 p.m., <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106272/diff/2-3/?file=82326#file82326line123" style="color: black; font-weight: bold; text-decoration: underline;">plasma/declarativeimports/qtextracomponents/fullmodelaccess.cpp</a>
<span style="font-weight: normal;">
(Diff revisions 2 - 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QModelIndex FullModelAccess::rootIndex() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">122</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">q</span>Warning</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Doing weird things..."</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">121</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">k</span>Warning</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Doing weird things..."</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am actually wondering if hitting this condition is really weird:
>From QML, setting the model can only be done through the rootIndex property, so if I am using the model to filter model1 and then want to change it to filter model2, I am going to pass to setRootIndex() an index which is not from the current source model.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You are correct, I added this when I didn't get the model from the index.
It's really convenient to get it from the index, though, because otherwise you get to weird states because you don't know when the model when setting the index.
I removed the warning.</pre>
<br />
<p>- Aleix</p>
<br />
<p>On August 31st, 2012, 7:53 a.m., Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aurélien Gâteau and Marco Martin.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Aug. 31, 2012, 7:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a component called ListifyModel (yeah, I hate the name too). The idea behind is to expose as a QAbstractListModel any part of a QAbstractItemModel.
This solves the problem we have in QML given the limitation that ListView only displays the first column of the root items. Here we can specify what column we want and what root index we want to have.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's a passing unit test, albeit limited.
I also tested it with a QML example I had with KPeople. If anybody is interested I can provide it too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/qtextracomponents/CMakeLists.txt <span style="color: grey">(05a1195)</span></li>
<li>plasma/declarativeimports/qtextracomponents/fullmodelaccess.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/qtextracomponents/fullmodelaccess.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/qtextracomponents/qtextracomponentsplugin.cpp <span style="color: grey">(429282e)</span></li>
<li>plasma/declarativeimports/qtextracomponents/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/qtextracomponents/tests/fullmodelaccesstest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/qtextracomponents/tests/fullmodelaccesstest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106272/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>