<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105673/">http://git.reviewboard.kde.org/r/105673/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 26th, 2012, 10:57 a.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what i can say quickly looking at it is that it looks cleaner and more expandible than the old one.
of course is a bit big, so will indeed need more testing, but most important thing for the first merge is that there aren't significant regressions compared to what there is already (konq, firefox, opera)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello, any update on this one? Could it be shipped for 4.10?
Thanks</pre>
<br />
<p>- Marco</p>
<br />
<p>On July 26th, 2012, 10:23 a.m., Marco Gulino wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Gulino.</div>
<p style="color: grey;"><i>Updated July 26, 2012, 10:23 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've nearly finished my work on the Bookmarks krunner, at least I think it's ready for a review.
Main focus: add support for chrome (and chromium).
Side effects: refactoring, a few unit tests, and Favicons for firefox (it's very similar for chrome, they're stored as sqlite blob, so adding favicon for chrome meant making easy to add them to firefox too).
I also removed some code seeming dead, or duplicated.
I'm mostly unhappy with the favicon fetch from firefox and chrome: i had to save them to temp file since it's impossible to load QPixmap in krunner plugins.
What's still missing: maybe a little more testing (both unit and manual) and cleanup.
branch: plasma/bookmarksrunner-chrome-gulino, path /plasma/generic/runners/bookmarks
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/runners/bookmarks/.gitignore <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/CMakeLists.txt <span style="color: grey">(39d7834)</span></li>
<li>plasma/generic/runners/bookmarks/bookmarkmatch.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/bookmarkmatch.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/bookmarksrunner.h <span style="color: grey">(d7545af)</span></li>
<li>plasma/generic/runners/bookmarks/bookmarksrunner.cpp <span style="color: grey">(aa3d45d)</span></li>
<li>plasma/generic/runners/bookmarks/bookmarksrunner_defs.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browserfactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browserfactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/chrome.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/chrome.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/chromefindprofile.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/chromefindprofile.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/findprofile.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/firefox.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/firefox.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/kdebrowser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/kdebrowser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/opera.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/opera.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/favicon.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/favicon.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/faviconfromblob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/faviconfromblob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/fetchsqlite.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/fetchsqlite.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/plasma-runner-bookmarks.desktop <span style="color: grey">(b752591)</span></li>
<li>plasma/generic/runners/bookmarks/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/tests/chrome-config-home/.config/chromium/Local <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-Sample.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-SecondProfile.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/tests/testchromebookmarks.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/tests/testchromebookmarks.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105673/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>