<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105849/">http://git.reviewboard.kde.org/r/105849/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 5d1e8bc806e4230d77e5adce00ec3812c31d7dee by Martin Koller to branch KDE/4.9.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 15th, 2012, 7:06 p.m., Martin Koller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Martin Koller.</div>
<p style="color: grey;"><i>Updated Aug. 15, 2012, 7:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this patch changes the width of the task group popup to be able to read the full title of the window.
The minimum width is like it was before, but if the title is wider, it will increase the width up to 80% of the available
corona width.
This patch is in line with the goals of the task applet. In the README I find:
"The tasks applet should try to make it as easy as possible
for the user to perform a 'context switch' between the different
tasks they are performing."
Before my patch I could often not easily find which group item I have to click as I could not
read the full title of the window.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">checked panel on all screen edges, ungrouped/grouped task items, added, removed group items (windows)
with longer titles while/before opening the popup.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=302125">302125</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/tasks/abstracttaskitem.cpp <span style="color: grey">(835fb27)</span></li>
<li>plasma/desktop/applets/tasks/taskgroupitem.cpp <span style="color: grey">(d846a4c)</span></li>
<li>plasma/desktop/applets/tasks/taskitemlayout.cpp <span style="color: grey">(079c18d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105849/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>