<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105893/">http://git.reviewboard.kde.org/r/105893/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">5 minutes fixed in code.. Two possible suggestions.
1. Could you perhaps use the screensaver which probably means that this auto deletion is always done except when the screensaver is running?
2. Use KIdleTime thus always auto delete notifications except when the user is idle. http://api.kde.org/4.8-api/kdelibs-apidocs/kutils/html/classKIdleTime.html
Just a few suggestions :)</pre>
<br />
<p>- Mark</p>
<br />
<p>On August 6th, 2012, 11:01 a.m., Martin Koller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Martin Koller.</div>
<p style="color: grey;"><i>Updated Aug. 6, 2012, 11:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">as discussed in private mail, the auto-deletion timer shall only be started from one single place, which is
the notificationmanager, which starts the timer only if there is user activity on the desktop so that a notification
which arrives while the user is not at his desk does not get deleted unseen.
Also, the auto-deletion timeout is reduced to 5 minutes, as I think 20 minutes is much too long (Notifications should only
provide temporary information for the user for things happening NOW. After some minutes the information is irrelevant).
For information which is of critical importance, the application can use the urgency=2 which avoids the auto-deletion completely.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/notifications/core/notification.cpp <span style="color: grey">(1e1350e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105893/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>