<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105769/">http://git.reviewboard.kde.org/r/105769/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 440c1a8b2f3332dcd184a3d463c732f136c4b7b8 by Jekyll Wu to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 28th, 2012, 1:11 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated July 28, 2012, 1:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The cause is simple: two flags m_detailedMenuEntries and m_detailedEntriesNamesFirst are never explicitly initialized. So their values are random, and the final results are unpredictable.
The patch simply initializes both as true, since that seems to be the default behavior of kickoff.
The git history shows those two flags seem to be something left over from the KDE3 era. Maybe they should just be removed from the code. However, I'm not familiar with the code and the history, so this simple patch should be safe choice.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304177">304177</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmenuedit/treeview.cpp <span style="color: grey">(54feff7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105769/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>