<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105405/">http://git.reviewboard.kde.org/r/105405/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 19th, 2012, 9:04 a.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">thanks, wouldn;t have remembered ;)
the changes seems good, but i'm not sure about giving kickoff a copy of the tabbar.
any reason this is not proposed as a patch for the tabbar component itself?</pre>
</blockquote>
<p>On July 19th, 2012, 12:55 p.m., <b>Greg T</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Of course I could do that. But I didn't know if such a general change would be welcome. Maybe people love equally sized blocks?</pre>
</blockquote>
<p>On July 19th, 2012, 2:23 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i really think we shouldn't start to customize the components in a single applet like that.
what could be done is:
as implicit width of the tabbar should be a width such that all tabs have the same width that is the one of the largest tab, so by default it would attempt to never elide (probably some work in the bindings is needed to export this as preferred width of the applet).
if it's forced to be smaller it starts to elide the text.</pre>
</blockquote>
<p>On July 20th, 2012, 6 p.m., <b>Greg T</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure if I can follow you, but basically you describe the current behavior. Every TabButton got a 'implicitHeight: label.paintedHeight' and the layout calculates a minimum implicitWidth that doesn't elide text. The export is missing, though.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">basically would be kickoff opening by default wide enough to make all text fit (maybe still not going over a maximum width)
i'm not sure what's still missing in the bindings to make this feasible tough</pre>
<br />
<p>- Marco</p>
<br />
<p>On July 1st, 2012, 8:42 p.m., Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Marco Martin and Martin Gräßlin.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated July 1, 2012, 8:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Heda,
This patch addresses the layout of the tab bar. The tab buttons are now sized depending of their text width.
I just copied the tabbar code from kde-runtime and exchanged taskbarLayout. My main question is: Can I do this more elegantly without copying TabBar.qml?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/kickoff/package/contents/ui/KickoffTabBar.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/applets/kickoff/package/contents/ui/Private/TabBarLayout.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml <span style="color: grey">(4d53208)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105405/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>