<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105447/">http://git.reviewboard.kde.org/r/105447/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, i think right now is the least painful way to have it right.
the code is ok.
what we have to remember is for plasma2 we may want to not have to do that again, so api in libplasma may heve to be retought.
but +1 for doing this way for now</pre>
<br />
<p>- Marco</p>
<br />
<p>On July 5th, 2012, 9:05 a.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, KDE Usability and Marco Martin.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated July 5, 2012, 9:05 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When the widget explorer is oriented vertically, applet tooltips shows on top of other applets instead of showing on the right or on the left. This patch fixes it in a not-too intrusive way (original patch affected kdelibs and kde-runtime as well). If possible I would like this patch to be applied to the KDE/4.9 branch as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with panels on all edges.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmagenericshell/widgetsexplorer/package/contents/ui/main.qml <span style="color: grey">(cc84e6c)</span></li>
<li>libs/plasmagenericshell/widgetsexplorer/widgetexplorer.h <span style="color: grey">(31308d2)</span></li>
<li>libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp <span style="color: grey">(9b19f88)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105447/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105447/s/616/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/05/widget-explorer-tooltip_400x100.png" style="border: 1px black solid;" alt="before-after" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>