<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105159/">http://git.reviewboard.kde.org/r/105159/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b318063036fdc482996e4cc24c7dff93e3e72cc9 by Aurélien Gâteau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 6th, 2012, 2:23 p.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Sebastian Kügler.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated June 6, 2012, 2:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Plasma::LineEdit uses the button text color for its text. Do the same in PlasmaComponents.TextField to avoid white text on white background with Oxygen theme.
Also use button text color for PC.TextArea because it uses the same background frame as PC.TextField (P.TextEdit, its C++ equivalent, does not have any background frame)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Run Plasma widget gallery from kdeexamples before and after the patch, see attached screenshots.
Note: the "before" screenshot corresponds to the state of the classes after I reverted the changes which hardcoded their text colors to black.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/plasmacomponents/platformcomponents/touch/TextArea.qml <span style="color: grey">(244e8c3)</span></li>
<li>plasma/declarativeimports/plasmacomponents/platformcomponents/touch/TextField.qml <span style="color: grey">(76aff68)</span></li>
<li>plasma/declarativeimports/plasmacomponents/qml/TextArea.qml <span style="color: grey">(f82842e)</span></li>
<li>plasma/declarativeimports/plasmacomponents/qml/TextField.qml <span style="color: grey">(1230d33)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105159/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105159/s/596/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/06/06/gallery-before_400x100.png" style="border: 1px black solid;" alt="before" /></a>
<a href="http://git.reviewboard.kde.org/r/105159/s/597/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/06/06/gallery-after_400x100.png" style="border: 1px black solid;" alt="after" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>