<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105032/">http://git.reviewboard.kde.org/r/105032/</a>
     </td>
    </tr>
   </table>
   <br />









<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/105032/diff/4/?file=66107#file66107line25" style="color: black; font-weight: bold; text-decoration: underline;">publisher/remoteinstaller/remoteinstaller.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">RemoteInstaller::RemoteInstaller(const QString& username, const QString& hostname,</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">m_widget</span> <span class="o">=</span> <span class="n">qobject_cast</span><span class="o"><</span> <span class="n">QWidget</span><span class="o">*</span> <span class="o">></span><span class="p">(</span><span class="n">parent</span><span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't do this. What if someone uses your class and passes a qobject that isn't a qwidget as the parent? You'll get a crash despite them using your API "correctly".

Change constructor to:

RemoteInstaller::RemoteInstaller(const QString& username, const QString& hostname,const QString& source, QWidget* parent): 
QObject(parent),
m_widget(parent)
{
...

}

.

</pre>
</div>
<br />



<p>- David</p>


<br />
<p>On June 3rd, 2012, 9:32 a.m., Giorgos Tsiapaliwkas wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>


<p style="color: grey;"><i>Updated June 3, 2012, 9:32 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello,

in terietor/remoteinstaller I have create a remote installer.
The goal is to install the projects remotely to another computer.

You access the remote install either inside plasmate or using the plasmaremoteinstaller binary.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I couldn't find any bugs in the remote installer, but the proccess fails during KIO::copy.
Apparently I am not writing correct something in the fish protocol.
Right now the remote installer tries to do the above

KIO::copy("/home/terietor/.kde4/share/apps/plasmate/project, "fish://user@ip/home/user")

but it fails
</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(12f8a3a)</span></li>

 <li>publisher/publisher.h <span style="color: grey">(5f40ae0)</span></li>

 <li>publisher/publisher.cpp <span style="color: grey">(fd87364)</span></li>

 <li>publisher/remoteinstaller/remoteinstaller.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>publisher/remoteinstaller/remoteinstaller.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>publisher/remoteinstaller/remoteinstaller.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>publisher/remoteinstaller/remoteinstallerdialog.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>publisher/remoteinstaller/remoteinstallerdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>publisher/remoteinstaller/standalone/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>publisher/remoteinstaller/standalone/plasmaremoteinstaller.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105032/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>