<div class="gmail_quote">On Thu, May 31, 2012 at 3:36 PM, Trever Fischer <span dir="ltr"><<a href="mailto:tdfischer@fedoraproject.org" target="_blank">tdfischer@fedoraproject.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="im">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105112/" target="_blank">http://git.reviewboard.kde.org/r/105112/</a>
</td>
</tr>
</tbody></table>
<br>
</div><div class="im"><blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<p style="margin-top:0">On May 31st, 2012, 10:09 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">the real fubar here is that it stores this information internally in its own config file. this really ought to be stored/retrieved from nepomuk and/or zeitgeist.
i've cc'd Trever on this because he may have something to say about that as well.</pre>
</blockquote>
</blockquote>
</div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I actually just recently patched Dragon to do so, and it took very few lines: <a href="http://quickgit.kde.org/index.php?p=dragon.git&a=commitdiff&h=92fb6296e424dc829e0c5cc541aa3581856d2098" target="_blank">http://quickgit.kde.org/index.php?p=dragon.git&a=commitdiff&h=92fb6296e424dc829e0c5cc541aa3581856d2098</a>
Since Kickoff uses QAbstractItemModels, switching things to use a QZeitgeist::LogModel should be trivial. Alternatively, implementing the RecentApplications class to use Zeitgeist can be trivial as well, and would seem like the easiest way to do things.</pre>
<span class="HOEnZb"><font color="#888888">
<br>
<p>- Trever</p></font></span><div class="im">
<br>
<p>On May 31st, 2012, 10:08 a.m., Andriy Gapon wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image:url('');background-repeat:repeat-x;border:1px black solid">
<tbody><tr>
<td>
<div>Review request for Plasma and Trever Fischer.</div>
<div>By Andriy Gapon.</div>
<p style="color:grey"><i>Updated May 31, 2012, 10:08 a.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Currently recent applications list in kickoff is saved only when kickoff gracefully exits. This could be a minor annoyance when X/KDE/plasma crashes. I think that saving the list on every update to it should be a good idea. It should be a low overhead too, because the list changes only when a user launches an application via KDE.</pre>
</td>
</tr>
</tbody></table>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=206511" target="_blank">206511</a>
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>plasma/desktop/applets/kickoff/core/recentapplications.cpp <span style="color:grey">(3e05389)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105112/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div></div>
</div>
<br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br>
<br></blockquote></div><br><div>This is a bit off topic for the review thus responding by mail.</div><div><br></div><div>When i read the title i immediately thought: "ZEITGEIST!" ;)</div><div>Anyhow, i'd like to know a little thingy about the RecentApplications class. Is that class being called for every application that gets started or only for applications that get started through kickoff? (i'm betting the latter one is the case though i could be wrong..)</div>
<div><br></div><div>Assuming it's the latter one, is there any place in KDE where every single application passes through when it gets started? Since that would be the perfect place to add zeitgeist support! Then just let Kickoff read the recently used applications from zeitgeist.</div>
<div><br></div><div>Just a random idea :)</div><div><br></div><div>Cheers,</div><div>Mark</div>