<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105008/">http://git.reviewboard.kde.org/r/105008/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 22nd, 2012, 12:52 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"nepomuk works differently" should not be a reason for this particular change.
the question is whether to store the icons in nepomuk or not. if they are stored in nepomuk, then the information stays with the activities. if they are stored outside of nepomuk, then when we want to do things like migrate activities it becomes messier and we lose visibility on the connection between the image and the activity.</pre>
</blockquote>
<p>On May 22nd, 2012, 3:16 p.m., <b>David Narváez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review request has nothing to do with storing icons in Nepomuk or not. It has to do with what is returned to a client when it requests an icon for an activity - if we wait for Nepomuk to start and then return the icon there or just use the config file which already has the info. Icons are still stored in Nepomuk and sync'ed later in the code once Nepomuk is available.</pre>
</blockquote>
<p>On May 22nd, 2012, 4:37 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">let me rephrase for clarity: storing activity data (esp duplicate data) outside of nepomuk all to work around annoyances (like the one your patch addresses) or to placate people who insist they won't enable nepomuk makes no sense at this point.
it would be far more sensible to ensure that this data is consistently and quickly available from nepomuk than keeping another cache of this information outside of nepomuk.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">libkactivities' master has moved far into the direction of caching the info in the config while syncing with Nepomuk when available. The behavior proposed in this patch is actually sort of a backport of master's behavior.
I, on the other hand, tried my best to depend on Nepomuk to get the info but there seems to be no reliable way of getting the info in every possible case without at least breaking the ABI - not to mention anything about "quickly". I could elaborate but I don't know if this is the best place to do so.</pre>
<br />
<p>- David</p>
<br />
<p>On May 22nd, 2012, 3:12 a.m., David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Ivan Čukić.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated May 22, 2012, 3:12 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since we can't trust Nepomuk anymore now that ontologies are loaded asynchronously, we better implement the approach we have in master.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Log out and back in. Before this patch, icons would probably load later, or not load at all. Now icons are displayed right away when desktop is loaded.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=298684">298684</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>service/ActivityManager.cpp <span style="color: grey">(8927c43)</span></li>
<li>service/ActivityManager_p.h <span style="color: grey">(3ea1d8a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105008/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>