<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104592/">http://git.reviewboard.kde.org/r/104592/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Merged to master with commit bf1a11f5d9bcf73ba8f071bc4cd532ed8652e1d3</pre>
<br />
<p>- Viranch</p>
<br />
<p>On April 13th, 2012, 6:18 p.m., Viranch Mehta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Viranch Mehta.</div>
<p style="color: grey;"><i>Updated April 13, 2012, 6:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch essentially contains the new QML lock logout applet, along with required changes to powermanagement engine.
The patch contains *some* irrelevant code too (in powermanagement data engine) since the same branch has QML battery applet. So it'd be best to checkout plasma/viranch/powermanagementservices branch and compile plasma/generic/{applets/lockout,dataengines/powermanagement} instead of using the attached patch.
Two pending issues with the applet:
- There is no shine on the icons on hover.
- Sleep/Hibernate actions do not ask for confirmation, as does the current C++ version
Comments welcome on this thread :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Tested inside horizontal/vertical panels and floating on desktop, sizing works as expected.
- There may be some unexpected behavior if the panel containing the applet is changed from being horizontal to vertical or vice-versa.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/lock_logout/CMakeLists.txt <span style="color: grey">(a19615b)</span></li>
<li>plasma/generic/applets/lock_logout/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/lock_logout/contents/ui/config.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/lock_logout/contents/ui/data.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/lock_logout/contents/ui/lockout.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/lock_logout/lockout.h <span style="color: grey">(94f33cf)</span></li>
<li>plasma/generic/applets/lock_logout/lockout.cpp <span style="color: grey">(830e64b)</span></li>
<li>plasma/generic/applets/lock_logout/lockoutConfig.ui <span style="color: grey">(d9285c2)</span></li>
<li>plasma/generic/applets/lock_logout/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/lock_logout/plasma-applet-lockout.desktop <span style="color: grey">(d8a4337)</span></li>
<li>plasma/generic/dataengines/powermanagement/CMakeLists.txt <span style="color: grey">(9f2a528)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementengine.h <span style="color: grey">(20642c2)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementengine.cpp <span style="color: grey">(5572fcb)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementjob.h <span style="color: grey">(2c32015)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementjob.cpp <span style="color: grey">(e205bb0)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementservice.operations <span style="color: grey">(ad1301f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104592/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104592/s/526/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/13/lockout_2_400x100.png" style="border: 1px black solid;" alt="Screenshot of the applet on desktop" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>