<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104716/">http://git.reviewboard.kde.org/r/104716/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On April 29th, 2012, 12:18 p.m., <b>Marco Martin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, i think is to merge at this point.

it can be only partial, but the api can map to qml only so much, so i think is as far it can go.

to me, the only blocker so far(see below) is that doesn't depend from plasma at all, so should be in the kde namespace</pre>
 </blockquote>







</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You haven't say your opinion about those,

a. there is tests/contents/code/klocaleqmltest.qml I believe that it should be tests/contents/ui/main.qml
b. the test plasmoid is exported as org.kde.klocaleqmltest it should be org.kde.example.localetest
c. Locale::setActiveCatalog and Locale::setMainCatalog since we didn't want the bindings to influence the core functionality.

so I guess that you agree. Correct?</pre>
<br />








<p>- Giorgos</p>


<br />
<p>On April 24th, 2012, 8:36 p.m., Giorgos Tsiapaliwkas wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>


<p style="color: grey;"><i>Updated April 24, 2012, 8:36 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello,

this branch contains QML bindings for KLocale. I believe that is the time to review it here.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there is a plasmoid in kde-runtime/plasma/declarativeimports/locale/tests in which I have exported every property/q_invokable.

Some issues that I will like to mention

a. there is tests/contents/code/klocaleqmltest.qml I believe that it should be tests/contents/ui/main.qml
b. the test plasmoid is exported as org.kde.klocaleqmltest it should be org.kde.example.localetest
c. Locale::setActiveCatalog and Locale::setMainCatalog since we didn't want the bindings to influence the core functionality.

what do you think?</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/locale/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/declarativeimports/locale/calendarsystem.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/declarativeimports/locale/calendarsystem.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/declarativeimports/locale/locale.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/declarativeimports/locale/locale.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/declarativeimports/locale/localebindingsplugin.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/declarativeimports/locale/localebindingsplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/declarativeimports/locale/qmldir <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/declarativeimports/locale/tests/contents/code/klocaleqmltest.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/declarativeimports/locale/tests/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104716/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>