<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104428/">http://git.reviewboard.kde.org/r/104428/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104428/diff/3/?file=55367#file55367line60" style="color: black; font-weight: bold; text-decoration: underline;">service/plugins/globalshortcuts/globalshortcuts.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void GlobalShortcutsPlugin::listActivitiesFinished(QDBusPendingCallWatcher *watcher)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">60</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span class="o">&</span> <span class="n">activity</span><span class="p">,</span> <span class="n">activities</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You can replace the code from this line to line 81 using something like this:
// m_activities is class member variable, not local.
m_activities = activities;
updateNextActivityName(0);
// end of GlobalShortcutsPlugin::listActivitiesFinished
void GlobalShortcutsPlugin::updateNextActivityName(QDBusPendingCallWatcher * watcher)
{
if (watcher) {
QDBusPendingReply<QString> reply = *watcher;
if (reply.isValid()) {
KAction * action = m_actionCollection->addAction(QString("switch-to-activity-%1").arg(watcher->property("activity").toString());
action->setText(i18nc("@action", "Switch to activity \"%1\"", reply.value()));
action->setGlobalShortcut(KShortcut());
connect(action, SIGNAL(triggered()), m_signalMapper, SLOT(map()));
m_signalMapper->setMapping(action, activity);
}
}
if (m_activities.isEmpty()) {
connect(m_signalMapper, SIGNAL(mapped(QString)), this, SLOT(setCurrentActivity(QString)));
m_actionCollection->readSettings();
return;
}
QString activity = m_activities.takeFirst();
QDBusPendingReply<QString> reply = m_dbusInterface->asyncCallWithArgumentList(
QDBus::AutoDetect,
"ActivityName",
QList<QVariant>() << activity
);
QDBusPendingCallWatcher* watcher = new QDBusPendingCallWatcher(reply, this);
watcher->setProperty("activity", activity)
connect(watcher, SIGNAL(finished(QDBusPendingCallWatcher*)),
this, SLOT(updateNextActivityName(QDBusPendingCallWatcher*)));
}</pre>
</div>
<br />
<p>- Lamarque Vieira</p>
<br />
<p>On March 31st, 2012, 7:48 p.m., makis marimpis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan Čukić.</div>
<div>By makis marimpis.</div>
<p style="color: grey;"><i>Updated March 31, 2012, 7:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(follows discarded review: 104391)
The plugin adds global keyboard shortcuts for changing the activity.
Defaults start from Qt::MetaModifier + Qt::Key_F1.
Initially, this functionality was implemented (without correct results) using KActitivities::Controller.
Using DBus seems fine, just that... it forces kamd to start with 3-4 seconds delay - so it really needs modification/and i would like more guidance related to dbus :D.
Other than that, feedback is needed. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Logged in.
Used the default shortcuts to switch activities.
It works!</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=265069">265069</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=273467">273467</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>service/plugins/CMakeLists.txt <span style="color: grey">(3e965c0a201a7eee2c9868fcf163cf55af636858)</span></li>
<li>service/plugins/globalshortcuts/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>service/plugins/globalshortcuts/globalshortcuts.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>service/plugins/globalshortcuts/globalshortcuts.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104428/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>