<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104422/">http://git.reviewboard.kde.org/r/104422/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Martin Gräßlin.</div>
<div>By Richard Stockton.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kickoff needs a way to enter the "All Applications" Tab, using only the keyboard.
With this patch, pressing 'Qt::Key_Up' or 'Qt::Key_Down' will leave the 'Launcher' and enter the "Applications" View content area, when the "Applications" icon is highlighted in the tab bar. From inside the "All Applications" Widget, the User may press Qt::Key_Tab to return to the Launcher (for switching to another tab, or for performing a search.) Qt::Key_Tab must generally be pressed TWICE.
This makes entry into the "Applications" tab, and exit back to the Launcher, the same as the other tabs (i.e., "Favorites", "Recently Used", "Computer", and "Leave"). This is a patch only for 4.8, because widget-based Kickoff will be replaced with a QML launcher in KDE 4.9.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiled, tested, and using in production.
Note for testers: There is one bit of weirdness, not new, and it's the same with all of the Other Tabs: From inside the tab's content area, you must make TWO KeyPress events of Qt::Key_Tab in order to highlight the search bar TextEdit Widget properly. I don't know exactly "where" focus goes after the first Tab keyPressEvent, when neither the content area nor the search TextEdit are highlighted. (And I'm not going to waste time figuring it out, because this all gets replaced with 4.9.)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=276932">276932</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=296696">296696</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/kickoff/ui/launcher.cpp <span style="color: grey">(3662ef0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104422/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>