<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104391/">http://git.reviewboard.kde.org/r/104391/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 24th, 2012, 6:12 p.m., <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think this is the right approach of dealing with the keyboard shortcuts for activities:
- not discoverable
- clashes with the filter bar (which is the only way to discover the feature)
- doesn't work in general case of user having more than 10 activities
- the user needs to open the activity bar, count the #number of the desired activity (the order can change), and then press the key.
I'd rather have it in kactivitymanagerd - to register global shortcuts, and that the user can set them in the system settings where the shortcuts for other programs are set.</pre>
</blockquote>
<p>On March 24th, 2012, 6:13 p.m., <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It can be a plugin for kamd...</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Honestly i wasn't satisfied with my initial approach either, i just wanted to fool around with the activitymanager plasma-thingy.
I think i can manage to add global shortcuts.
Now for the plugin part honestly i not quite sure how to implement it, perhaps with proper guidance :D</pre>
<br />
<p>- makis</p>
<br />
<p>On March 23rd, 2012, 7:35 p.m., makis marimpis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Ivan Čukić.</div>
<div>By makis marimpis.</div>
<p style="color: grey;"><i>Updated March 23, 2012, 7:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds keyboard shortcuts (0-9) for quick selecting an activity through ActivityManager plasma (Meta + Q).
My main concern is how to focus to FilterBar; probably add a shortcut like "Ctr+S" via buddy system? (random thought).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Run ActivityManager and select and press a number.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=265069">265069</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=273467">273467</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/activitymanager/activitylist.h <span style="color: grey">(09ed686)</span></li>
<li>plasma/desktop/shell/activitymanager/activitylist.cpp <span style="color: grey">(3327cdf)</span></li>
<li>plasma/desktop/shell/activitymanager/activitymanager.cpp <span style="color: grey">(5aeaccf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104391/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>