<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104226/">http://git.reviewboard.kde.org/r/104226/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 20th, 2012, 10:02 p.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td><a href="/r/104226/s/482/" style="color: black; font-weight: bold; font-size: 9pt;">battery.png</a></td>
</tr>
<tr>
<td><a href="http://git.reviewboard.kde.org/r/104226/s/482/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/20/battery_8_222_28_36.png" style="border: 1px black solid;" alt=""></a></td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks kind bad. There should be a certain amount of padding.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is already some default padding in the popup. It is stripped off while viewing in plasmoidviewer for some reason, notice the absence of top left and bottom left rounded corners. Should look fine when added to an actual workspace.</pre>
<br />
<p>- Viranch</p>
<br />
<p>On March 20th, 2012, 9:44 p.m., Viranch Mehta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Viranch Mehta.</div>
<p style="color: grey;"><i>Updated March 20, 2012, 9:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I fixed the QML battery monitor to be fairly usable and this diff merges it to master.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Applet and dataengine both tested and work fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/CMakeLists.txt <span style="color: grey">(2dedcb2)</span></li>
<li>plasma/generic/applets/batterymonitor/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/README.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/battery-oxygen.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/ui/config.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementengine.h <span style="color: grey">(20642c2)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementengine.cpp <span style="color: grey">(5572fcb)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementjob.h <span style="color: grey">(2c32015)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementjob.cpp <span style="color: grey">(e205bb0)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementservice.operations <span style="color: grey">(ad1301f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104226/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104226/s/482/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/20/battery_400x100.png" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>