<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104318/">http://git.reviewboard.kde.org/r/104318/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 18th, 2012, 7:57 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what is the use case for knowing if it is animated or not? this seems like an internal implementation detail?</pre>
</blockquote>
<p>On March 18th, 2012, 8:12 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I assume it's more for setting whether it animates or not. (when the user clicks on the slider, whether it slides to the new value) Tbh, I'm with you that it's not needed.
However the gallery is full of
Slider {
....
animated:true;
}
and the documentation at the top of this file says:
bool animated
This property holds if the slider will animate or not when other point is clicked,
and the slider handler is not being dragged. The default value is false.
So it looked to me like it was meant to exist, and was missed off.</pre>
</blockquote>
<p>On March 19th, 2012, 10 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it did exist, but was pulled from the code as it should be an implementation detail that is kept consistent within the component set, not controlled by the individual application using the components. from irc today:
[10:51] <aseigo> notmart: https://git.reviewboard.kde.org/r/104318/#review11571 <--- do you know why there is an animated property?
[10:52] * notmart looks
[10:52] <notmart> should be definitely be something not controllable
[10:53] <notmart> aseigo: i'll say, remove it from the documentation rather adding in the code right?
[10:54] <notmart> i think i yanked it in the past but forgot from the docs
[10:58] <aseigo> cool. that's what i thought but figured i should ask :)
so the right fix would be to just remove the documentation :) please do so and commit at your leisure (closing this review in the process) ...</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cool, I should have checked the history.
Make sure Gallery/Sliders.qml is updated too.</pre>
<br />
<p>- David</p>
<br />
<p>On March 17th, 2012, 7:27 p.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 17, 2012, 7:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add missing property alias "animation" in Slider Plasma Component
Item now matches it's own documentation.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested in Component Gallery (which didn't work before!) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/plasmacomponents/qml/Slider.qml <span style="color: grey">(447dbb1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104318/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>