<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104086/">http://git.reviewboard.kde.org/r/104086/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 297b3e42e796afe1cd37df101d8b2c240b4625b0 by Aaron Seigo to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On February 26th, 2012, 10:18 p.m., Luc Menut wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Luc Menut.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2012, 10:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When I try in the plasma desktop console the algorithm that calculate the biggestId in systray-to-notifications-widget.js, it gives me a wrong result for biggestId and biggestId+1.
The real biggestId in my plasma-desktop-appletsrc is 82 ([Containments][76][Applets][82]).
The current algorithm gives me:
print(biggestId) -> 5
print(biggestId+1) -> 51
print(typeof(biggestId)) -> string
because in
for (var j in activity.widgetIds) {
if (j > biggestId) {
biggestId = j
}
j is the key (string key) of the array activity.widgetIds.
The suggested patch gives the good result.
regards,
Luc Menut - Mageia
PS: I don't have write access to kde git, so could you commit the change for me if the patch looks fine. Thanks.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested with KDE 4.8.0 (Mageia Cauldron)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/configupdates/systray-to-notifications-widget.js <span style="color: grey">(7a31de6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104086/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>