<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103632/">http://git.reviewboard.kde.org/r/103632/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Ivan Čukić.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2012, 5:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed typos</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am wondering what I am missing that I seem to be the only one to have hit this so far, but currently kde-workspace (at least master) does not build completely for me because the symbols from libkactivities.so are missing for anything linking against it.
The reason is for me that FindKActivities.cmake sets the var "KACTIVITIES_LIBS", but everywhere in the CMakeLists.txt "KACTIVITIES_LIBRARY" is used, resulting in an empty string added to the libs to link to -> fail.
Attached patch fixes this. Okay to commit?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Applied the patch and kde-workspace builds completely for me and plasma-desktop & co. runs fine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/activities/CMakeLists.txt <span style="color: grey">(a954c2a)</span></li>
<li>plasma/generic/runners/activities/CMakeLists.txt <span style="color: grey">(e630c36)</span></li>
<li>powerdevil/daemon/CMakeLists.txt <span style="color: grey">(35a4fd4)</span></li>
<li>powerdevil/kcmodule/activities/CMakeLists.txt <span style="color: grey">(a360f30)</span></li>
<li>kwin/CMakeLists.txt <span style="color: grey">(1fb4d76)</span></li>
<li>libs/taskmanager/CMakeLists.txt <span style="color: grey">(375a0d6)</span></li>
<li>plasma/desktop/applets/pager/CMakeLists.txt <span style="color: grey">(056f9d4)</span></li>
<li>plasma/desktop/shell/CMakeLists.txt <span style="color: grey">(e0b9a26)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103632/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>