<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103324/">http://git.reviewboard.kde.org/r/103324/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 90baea8b9fe7bb65931cd2bb55ca48180901e0ad by Jaime Torres to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 4th, 2011, 12:22 p.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Dec. 4, 2011, 12:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I will not comment about the trivial ones (including the change from postfix to prefix in non trivial data types).
Removed one duplicated Mask (unless there is one mask missing instead of the duplicated).
In solarsystem.h and timesource.cpp. I need this change for plasma being able to start (I use the clock applet), otherwise it crashes here.
In singleview.cpp avoid a possible null pointer dereference.
In stripwidget.cpp. Was it supposed to be a "boolean or" or a "bit or"?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the solarsystem change has been playing nice here one month without crashes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/time/timesource.cpp <span style="color: grey">(47025ad)</span></li>
<li>plasma/generic/dataengines/time/solarsystem.h <span style="color: grey">(10d6b30)</span></li>
<li>plasma/generic/dataengines/tasks/tasksource.cpp <span style="color: grey">(0788cc4)</span></li>
<li>plasma/generic/dataengines/calendar/calendarengine.cpp <span style="color: grey">(f8b3a90)</span></li>
<li>plasma/generic/dataengines/filebrowser/filebrowserengine.cpp <span style="color: grey">(1acd11f)</span></li>
<li>plasma/desktop/applets/tasks/abstracttaskitem.cpp <span style="color: grey">(6f75bc5)</span></li>
<li>plasma/desktop/shell/panelview.cpp <span style="color: grey">(98b8878)</span></li>
<li>plasma/desktop/shell/plasmaapp.cpp <span style="color: grey">(7902cb7)</span></li>
<li>plasma/generic/shells/plasma-windowed/singleview.cpp <span style="color: grey">(10d2113)</span></li>
<li>plasma/generic/tools/engineexplorer/main.cpp <span style="color: grey">(7aa4c4a)</span></li>
<li>plasma/generic/tools/plasmoidviewer/main.cpp <span style="color: grey">(5cd69a0)</span></li>
<li>plasma/generic/tools/wallpaperviewer/main.cpp <span style="color: grey">(c288056)</span></li>
<li>plasma/netbook/containments/sal/stripwidget.cpp <span style="color: grey">(cded4bc)</span></li>
<li>plasma/netbook/shell/plasmaapp.cpp <span style="color: grey">(b9d97cc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103324/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>