<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102631/">http://git.reviewboard.kde.org/r/102631/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 16th, 2011, 2 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good. and stripping unecessary whitespace is good (adding unecessary whitespace, by corallary, is not :)</pre>
</blockquote>
<p>On November 13th, 2011, 1:10 a.m., <b>Thomas Gahr</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry to bring this up so late - has this been applied yet? I don't have push access so I can't do it - would you do so if not, Aaron? Thanks!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, that's was I was confused about review 103093 already being applied...
I will commit this after the beta release.</pre>
<br />
<p>- Christoph</p>
<br />
<p>On September 16th, 2011, 2:10 p.m., Thomas Gahr wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Thomas Gahr.</div>
<p style="color: grey;"><i>Updated Sept. 16, 2011, 2:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KControl/randr: Make changes to the absolute X/Y coordinates of a display call setConfigDirty and thus enable the "apply" button.
In some situations the absolute X/Y position is the only thing the user needs to change. At the moment you need to make some dummy change (change resolution back and forth or alike) to enable the "apply" button. This is not a good user experience.
Sorry for the unnecessary whitespace-changes, qt-creator auto-strips unnecessary space upon saving. If everything else is fine with this patch and anybody insists on it I will update the patch dropping these changes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Backported the patch to kde-workspace sources 4.7.0 used in Fedora's KDE rpms (i.e. change valueChanged(int) to textChanged(const QString&), built a new rpm from the patched sources and tested it on my install. Works just as expected. I have yet to finish the setup of my kde-devel environment to test it on current master. Will keep you updated if it breaks anything.
[update] Works fine with current master</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/randr/outputconfig.cpp <span style="color: grey">(38c8386)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102631/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>