<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103061/">http://git.reviewboard.kde.org/r/103061/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On November 7th, 2011, 12:04 a.m., Andrius da Costa Ribas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdewin and Plasma.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2011, 12:04 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KWorkspace is currently built statically under windows, but there are several places it is not linked. There is no apparent reason for that. Also, dll linkage (import/exoirt) was not correct for building it as a dynamic lib. "kworkspace_export.h" and related changes are based on the code under libs/oxygen.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled under MSVC 2010. I'm looking other non-related issues that prevents other parts of kde-workspace being built completely.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kworkspace/CMakeLists.txt <span style="color: grey">(32cd11d)</span></li>
<li>libs/kworkspace/kactivityconsumer.h <span style="color: grey">(901aac1)</span></li>
<li>libs/kworkspace/kactivitycontroller.h <span style="color: grey">(3a02825)</span></li>
<li>libs/kworkspace/kactivityinfo.h <span style="color: grey">(3e271de)</span></li>
<li>libs/kworkspace/kdisplaymanager.h <span style="color: grey">(c215137)</span></li>
<li>libs/kworkspace/kwindowlistmenu.h <span style="color: grey">(2fe601b)</span></li>
<li>libs/kworkspace/kworkspace.h <span style="color: grey">(8868bf6)</span></li>
<li>libs/kworkspace/kworkspace_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kworkspace/screenpreviewwidget.h <span style="color: grey">(3ebb047)</span></li>
<li>plasma/desktop/applets/kickoff/CMakeLists.txt <span style="color: grey">(bc5fa2e)</span></li>
<li>plasma/generic/applets/lock_logout/CMakeLists.txt <span style="color: grey">(8381d46)</span></li>
<li>plasma/generic/containmentactions/contextmenu/CMakeLists.txt <span style="color: grey">(a1fc205)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103061/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>