<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103048/">http://git.reviewboard.kde.org/r/103048/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this seems heavy handed and in the wrong place: it should be managed by the visualization whether or not these things are locked. i'm somewhat ok with the idea of having a flag for this in the GroupManager, but i don't think it should be saved to any configuration as that will lead to synchronization issues between the visualization and the GroupManager. already as it is, GroupManagerPrivate::readLauncherConfig setting the flag from the config will prevent further calls made in GroupManager::readLauncherConfig from working and it will fail on the second time it is called.
so ... maybe yes to the flag, but no to saving it in the config by libtaskmanager. that belongs to the visualization for sure.</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On November 4th, 2011, 10:46 p.m., Craig Drummond wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Craig Drummond.</div>
<p style="color: grey;"><i>Updated Nov. 4, 2011, 10:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a lockLauncher setting, to prevent users from accidentally moving launchers.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/taskmanager/groupmanager.h <span style="color: grey">(90a27d2)</span></li>
<li>libs/taskmanager/groupmanager.cpp <span style="color: grey">(15118f0)</span></li>
<li>libs/taskmanager/taskactions.cpp <span style="color: grey">(fd69db1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103048/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>