<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103006/">http://git.reviewboard.kde.org/r/103006/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there are still whitespace issues around "if(" which should be "if (" and lack of spacing around operators such as = and != .. but let's just get this in; i realize how tedious this can be for you in trying to get such a large merge done. i can clean things up in-repo, and i have a few changes to make anyways (such as the static bool removal in that one strategy class). in future, it's important to keep consistent style throughout the shared code base. (what happens style-wise in the icon tasks widget is obviously up to you, but this is code we all have to work on and live with together for years to come. :)</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On November 2nd, 2011, 10:04 p.m., Craig Drummond wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Craig Drummond.</div>
<p style="color: grey;"><i>Updated Nov. 2, 2011, 10:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Store the order in which launchers are created
2. Add a new config option, separateLaunchers - so that applet can decide if launchers and tasks should be kept separate.
(Part of IconTasks' taskmanager changes)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/taskmanager/launcheritem.cpp <span style="color: grey">(20f0e7c)</span></li>
<li>libs/taskmanager/strategies/alphasortingstrategy.cpp <span style="color: grey">(9ec1aca)</span></li>
<li>libs/taskmanager/strategies/desktopsortingstrategy.cpp <span style="color: grey">(520fead)</span></li>
<li>libs/taskmanager/abstractgroupingstrategy.cpp <span style="color: grey">(4ed424a)</span></li>
<li>libs/taskmanager/abstractsortingstrategy.cpp <span style="color: grey">(390f6f0)</span></li>
<li>libs/taskmanager/groupmanager.h <span style="color: grey">(acaa142)</span></li>
<li>libs/taskmanager/groupmanager.cpp <span style="color: grey">(6e7ffa7)</span></li>
<li>libs/taskmanager/strategies/manualsortingstrategy.h <span style="color: grey">(113faab)</span></li>
<li>libs/taskmanager/strategies/manualsortingstrategy.cpp <span style="color: grey">(4409a6b)</span></li>
<li>libs/taskmanager/strategies/programgroupingstrategy.cpp <span style="color: grey">(5c43d03)</span></li>
<li>libs/taskmanager/taskgroup.h <span style="color: grey">(53c2871)</span></li>
<li>libs/taskmanager/taskgroup.cpp <span style="color: grey">(49140ae)</span></li>
<li>libs/taskmanager/taskitem.h <span style="color: grey">(5de8478)</span></li>
<li>libs/taskmanager/taskitem.cpp <span style="color: grey">(0a768e5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103006/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>