<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103007/">http://git.reviewboard.kde.org/r/103007/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 1st, 2011, 3:07 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the wholesale copying of KOpenWithDialog is very unfortunate and needs to be avoided if at *all* possible. why is it copied instead of used directly?
the really big issue is the exec()'ing of the dialog, however.
it would also be nice to be able to access individual launcher configuration via the individual launchers' context menu.
p.s. whitespace :)</pre>
</blockquote>
<p>On November 1st, 2011, 5:07 p.m., <b>Craig Drummond</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree the copying is bad - but without changing kdelibs I knew of no other way. The reason it is copied is that in KOpenWithDialog you cannot remove the "Open with" label (or change its text), or the kurlrequester below it.</pre>
</blockquote>
<p>On November 2nd, 2011, 1:57 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the Open With label is settable by using the KOpenWithDialog( const KUrl::List& urls, const QString& text, const QString& value, QWidget *parent = 0 ); constructor, so it could be set to something sensible for this case. as forthe KUrlRequester ... is that so bad? it allows the user to define an arbitrary exec on disk, the ultimate "last resort".</pre>
</blockquote>
<p>On November 2nd, 2011, 3:33 p.m., <b>Craig Drummond</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just tried KOpenWithDialog, and whilst you can set the text, and hide the checkboxes - the text entered in the url combo *must* be an application, not a desktop file. If you select a desktop file via the file selector you get the following error:
"'XXX.desktop' not found, please type a valid program name."
So, KOpenWithDialog would need updating to resolve this.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">indeed; i can fix that (though not today .. already at the end of my time alotments! aaaah! why only 24 hours in a day?!)</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On October 31st, 2011, 8:42 p.m., Craig Drummond wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Craig Drummond.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2011, 8:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. If fail to automatically find launcher, then prompt user to select from installed applications.
2. Add a config page, so that manualy set launchers may be adjusted.
(Part of IconTasks' taskmanager changes)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/taskmanager/CMakeLists.txt <span style="color: grey">(57f5f73)</span></li>
<li>libs/taskmanager/groupmanager.h <span style="color: grey">(acaa142)</span></li>
<li>libs/taskmanager/groupmanager.cpp <span style="color: grey">(6e7ffa7)</span></li>
<li>libs/taskmanager/kapplicationselectordialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/taskmanager/kapplicationselectordialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/taskmanager/launcherconfig.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/taskmanager/launcherconfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/taskmanager/launcherconfig.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/taskmanager/launcherproperties.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/taskmanager/launcherproperties.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/taskmanager/launcherproperties.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/taskmanager/taskactions.cpp <span style="color: grey">(0e6ba8e)</span></li>
<li>libs/taskmanager/taskitem.h <span style="color: grey">(5de8478)</span></li>
<li>libs/taskmanager/taskitem.cpp <span style="color: grey">(0a768e5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103007/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>