<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103004/">http://git.reviewboard.kde.org/r/103004/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 1st, 2011, 2:05 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a few issues with this patch, which can be divided into three types:
* over simplification of the menu; i am all for reducing the items in this menu, including moving more to the "Advanced" submenu (which should probably be renamed to "More Actions"), but this patch goes too far and renders the BasicMenu far, far les useful than it ought to be
* custom properties in the QActions are unneeded (see inline comments for how these can be handled without custom properties)
* whitespace correctness (the most trivial and least important of the issues)</pre>
</blockquote>
<p>On November 1st, 2011, 4:36 p.m., <b>Craig Drummond</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Didn’t think the 'basic' option would go down to well :-) Shall I just remove it from this patch? I still think they could be with simplifying...</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i think simplification is indeed useful. they are sub-optimal at the moment and could use with a nice scrubbing.</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On October 31st, 2011, 8:40 p.m., Craig Drummond wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Craig Drummond.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2011, 8:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Add NewInstance action to launch a new instance of an application.
2. Move toggle launcher action out of advanced menu.
3. Don't show application name in 'Show A Launcher' action, as might not know the real name at this time (e.g. no desktop file read).
4. Add application actions, to be shown at the top of the right-click menu. IconTasks uses this to show recent docuents, dock manager menu items, and unity items.
5. A ToolTipMenu class is created, so that tooltips may be give for menu items. This is so that IconTasks can display the full path of a documents in the recent documents menu.
6. Add option to have only basic window controls in menu.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/taskmanager/taskactions.h <span style="color: grey">(2b5a641)</span></li>
<li>libs/taskmanager/taskactions.cpp <span style="color: grey">(0e6ba8e)</span></li>
<li>libs/taskmanager/taskactions_p.h <span style="color: grey">(913966c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103004/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>