<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102770/">http://git.reviewboard.kde.org/r/102770/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 5th, 2011, 1:58 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">thanks for the patch ... :)
the coding style should follow the kdelibs style, but that's a minor thing. mostly just the one question regarding something noted in a code comment:</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can run the file through the astyle command before commiting.
As for the alpha channel, the note is there mainly in case somebody tries to use the function also in the future. For setBackgroundPixmap() it shouldn't matter AFAICT, and paintEvent() does a transparent fill after the transformation, so icons with translucent areas work fine.
</pre>
<br />
<p>- Luboš</p>
<br />
<p>On October 4th, 2011, 3:31 p.m., Luboš Luňák wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Luboš Luňák.</div>
<p style="color: grey;"><i>Updated Oct. 4, 2011, 3:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patches changes systemtray handling of XEmbed-based clients from various Xlib code to plain Qt code. The Xlib code was presumably introduced to handle non-native Qt graphics systems, but that can be somewhat more cleanly handled by forcing Qt to create XPixmap-based QPixmap.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with plasma-desktop and licq, with and without compositing enabled, seems to work the same way like without the patch.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/systemtray/protocols/fdo/x11embedcontainer.h <span style="color: grey">(fa47b9b)</span></li>
<li>plasma/generic/applets/systemtray/protocols/fdo/x11embedcontainer.cpp <span style="color: grey">(0aa5d96)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102770/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>