<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102757/">http://git.reviewboard.kde.org/r/102757/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 3rd, 2011, 10:18 a.m., <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A few remarks inline. I'm not really happy with it UI wise yet, and I'd like to see a screenshot of it in action. Especially that row of iconitems can already grow quite wide, imagine hibernate and suspend both available, and the whole thing in Russian: you need a wide screen display for it ;)
So needs some work.</pre>
</blockquote>
<p>On October 3rd, 2011, 10:32 a.m., <b>Dario Freddi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Agreed, that's why I submitted this review :P unfortunately I wrongly pushed this commit to master, but well --' Any suggestions on where to place it, considering also the combo box is going to go away?</pre>
</blockquote>
<p>On October 3rd, 2011, 11:24 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"inhibit" and "uninhibit" are things we understand as developers; i'm not sure many run-of-the-mill computer users will. it would probably be better to find some descriptive language for this that describes what is actually does, which is essentially "suspend power management features".
it should also not go alng with hibernate and suspend since those put the entire machine into an "off" state. the control for inhibiting pm should be closer to what it really controls, currently the drop down menu of choices.
it might make sense to simply note: "Power management features are on." with a button next to it change that. or a checkbox solution something like:
Battery: 39% (discharging)
AC Adapter: Not plugged in
Current strategy: Power saving
Power Management: [ x ] Enabled
Screen brightness: [============== o===========]
when the "Enabled" checkbox is unchecked, the current strategy label would grey out, reflecting it's disabled state. would require some user testing, but would seem more obvious that what is currently there to me.
btw: what will the combo box be replaced with? or why is it determined to not be of use anymore? is simple inhibition going to replace switching between profiles, under the assumption that one always wants either power management as a function of power available or else they want a full performance profile with no power management happening? (that's something i think might make sense; though i haven't done much fact gathering to support the idea ...)
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems sensible - even though the power strategy does not really apply anymore as it's just dependent on the battery state. But I like the check box, I'll resubmit the patch with something similar.
About the combo box issue; man, I guess you've been missing out on what happened yesterday on plasma-devel and k-c-d :P The flame-less version is here: http://drfav.wordpress.com/2011/10/02/forge-sprint-2011-power-management-and-its-future/</pre>
<br />
<p>- Dario</p>
<br />
<p>On October 2nd, 2011, 2:48 p.m., Dario Freddi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Sebastian Kügler.</div>
<div>By Dario Freddi.</div>
<p style="color: grey;"><i>Updated Oct. 2, 2011, 2:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As the title says. The feature works, but I'm wondering if we can make it look better. Any suggestions warmly appreciated :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/battery/battery.h <span style="color: grey">(d696014)</span></li>
<li>plasma/generic/applets/battery/battery.cpp <span style="color: grey">(c3a4f58)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102757/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>