<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102621/">http://git.reviewboard.kde.org/r/102621/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 15th, 2011, 9:46 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i find having the date on a line by itself very hard to read (due to no visual cue as to what information belongs with what city). i'd prefer it to remain on line (and not split == great!)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess it is impossible, then, until Qt fixes QTextDocument, void adjustSize (). This is the main problem, the one that breaks the lines, even when they are full of non breaking spaces. And this method is called twice, one in setContent and then one in checkSize in tooltip.cpp.
I've tried adding spaces, non breaking spaces, removing the table, adding more <td>.... it splits the data (specially when there is only one timezone with a large city name) to fit in the space within the sqrt(5/3*x*y) relation. (Why they did not choose the golden ratio? http://en.wikipedia.org/wiki/Golden_ratio)</pre>
<br />
<p>- Jaime Torres</p>
<br />
<p>On September 15th, 2011, 3:41 p.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Sept. 15, 2011, 3:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The first version of this patch only:
* allows Qt to split the date in the spaces, avoiding the split in the year.
* removes a <table> that makes the rendering harder
* adds a <br> to include an space between the dates and the event.
The second verion of this patch does:
* changes the table to show the city and time in one line and the date, in another line, always complete.
* removes a <table> that makes the rendering harder
* adds a <br> to include an space between the dates and the event.
Look at the screnshot.
Can remove the <br>, leave it, or add another before the table of cities.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Checked with zero, one and several timezones with short and large city names in two machines.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=260394">260394</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmaclock/clockapplet.cpp <span style="color: grey">(b1275af)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102621/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102621/s/262/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/09/15/plasma.260394.2_400x100.png" style="border: 1px black solid;" alt="version 2" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>