<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102291/">http://git.reviewboard.kde.org/r/102291/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 11th, 2011, 7:56 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">if i read this correctly, this means that the name of the package on the system needs to be the name of the dataengine. e.g. org.kde.foobar or whatever. is that going to be ok for packagers?
also, this work needs to shift to being written against the frameworks branch, and then only after libplasma2 has been merged into it. note that in libplasma2, there is no PackageMetadata class and the install package routine has moved into PackageStructure as well.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> if i read this correctly, this means that the name of the package on the system needs to be the name of the dataengine. e.g. org.kde.foobar or
> whatever.
That depends on how the PackageKit backend code is implemented. For RPM/Yum, we use virtual Provides of the plasma4(dataengine-org.kde.foobar) or plasma4(dataengine-foobar) (depending on what the data engine actually uses as its name) form. Looking up the correct package to provide a given data engine is PackageKit's job.
> also, this work needs to shift to being written against the frameworks branch, and then only after libplasma2 has been merged into it. note that
> in libplasma2, there is no PackageMetadata class and the install package routine has moved into PackageStructure as well.
I can prepare a patch against libplasma2. I'm not sure I'll be able to test it at this time though.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On August 10th, 2011, 10:10 p.m., Kevin Kofler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kevin Kofler.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2011, 10:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is another part of my GSoC 2011 work.
For script engines, the existing metadata (X-Plasma-API) is sufficient.
For data engines, we introduce a new metadata entry:
X-Plasma-RequiredDataEngines. Third-party packages will have to add this entry
to benefit from this feature at this time. Automatic support for scanning
package source code on installation (at least for some languages) is planned,
but the metadata entry is definitely the most efficient method.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Verified that it compiles without errors and that it successfully prompts for a missing Python script engine right after installing a Python widget (I used Veromix for my test) through KHNS (not only when actually using it) on Fedora 15. Also verified that there is no such prompt if plasma-scriptengine-python is already installed.
(The patch is against master (4.8), but applies without changes to the kdelibs 4.6.5 in Fedora 15, which is how I tested it.)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/package.cpp <span style="color: grey">(4c00d36)</span></li>
<li>plasma/packagemetadata.h <span style="color: grey">(b10f0e4)</span></li>
<li>plasma/packagemetadata.cpp <span style="color: grey">(59163b2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102291/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>