<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102261/">http://git.reviewboard.kde.org/r/102261/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 9th, 2011, 2:14 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure, but I think something was added to keybindings.cpp already, but I like this approach better :-)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You're right - kwinbindings.cpp does include a "Lock Screen" shortcut, but it will never actually aquire Ctrl+Alt+L (on an existing desktop), as it does not release KRunner's claim on that shortcut.
I'll update this request to include removing that definition.</pre>
<br />
<p>- Alex</p>
<br />
<p>On August 9th, 2011, 12:52 p.m., Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kwin, Plasma, Aaron J. Seigo, Martin Gräßlin, and Farhad Hedayati Fard.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2011, 12:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the farhad_hf/lockscreen branch (that moves screen locking functionality from krunner to kwin), the shortcut for locking the screen (Ctrl+Alt+L by default) remains in KRunner, which will not necessarily be running (when plasma is in "netbook" mode, for example). This moves the shortcut registration to kwin (including a necessary hack for unregistering krunner's claim on it).
(See also https://git.reviewboard.kde.org/r/101943/ ).
I can also merge latest master into the branch and/or add in a KWIN_BUILD_SCREENSAVER cmake option (as in the original review request) if you (Martin/Farhad) want.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krunner/krunnerapp.cpp <span style="color: grey">(55ac5ca)</span></li>
<li>kwin/screenlocker/screensaver/saverengine.h <span style="color: grey">(3384d4a)</span></li>
<li>kwin/screenlocker/screensaver/saverengine.cpp <span style="color: grey">(6c15be6)</span></li>
<li>kwin/useractions.cpp <span style="color: grey">(44685b9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102261/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>