<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102208/">http://git.reviewboard.kde.org/r/102208/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">adding the readSettings call in configChanged looks correct; however, moving the rest of the lines to graphicsWidget() means that unless the graphics widget is deleted after configuration, the configuration changes made while qalculate is running will not be picked up!
the lines moved into graphicsWidget() should be moved back into configChanged(), and configChanged() should be called from graphicsWidget() as well.</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On August 4th, 2011, 10:36 a.m., Jef Steelant wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jef Steelant.</div>
<p style="color: grey;"><i>Updated Aug. 4, 2011, 10:36 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If settings were changed in the qalculate plasmoid, these settings were not restored after the plasmoid was restarted (i.e. a reboot).
The settings are now read in the configChanged() method of the applet and restored correctly.
Extra cleanup: the signal of the m_baseDisplaySpin has also been changed to valueChanged(), since a QSpinBox does not have a toggled() signal.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changed settings and reloaded qalcultate - no issues</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/qalculate/qalculate_applet.cpp <span style="color: grey">(872e55f091fb8ada98a5623bfd36c54d45b95336)</span></li>
<li>applets/qalculate/qalculate_settings.cpp <span style="color: grey">(0cb9e494d3e4d787ed025cb88adee3c2e77626e0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102208/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>