<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102073/">http://git.reviewboard.kde.org/r/102073/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Even if NETWM spec says that the Desktop Layout is owned and maintained by a pager and not by the window manager, I disagree. It has been causing problems for years and is just wrong. Therefore this patch:
* moves the configuration of the number of rows from Pager Config UI to the Virtual Desktops KCM
* Number of rows is stored in the desktop section of KWin config file
* Virtual Desktops KCM updates the layout on change
* KWin sets the desktop layout on startup (as it sets the number of desktops and names)
* Pager gets the number of rows from the NetRootInfo instead of its own config
* Pager connects to KWin's reconfigure dbus signal to update the layout (KWindowSystem does not emit a signal)
This renders a major break with the NetWM spec:
* There is no process claiming the pager management selection any more
* If another pager is used together with KWin, KWin will ignore the settings of the pager
* If another window manager is used together with Plasma, the layout used by the window manager may not reflect the layout shown in the pager
As I think the concept of having Pager setting the desktop layout is broken, I will inform the NetWM spec mailing list when this patch is merged into master and recommend a change in the spec. Given that both GNOME Shell and Unity do have a combined Window Manager/Desktop Shell combination I expect them to ignore this part of the spec anyway.
Unrelated question: what is the use case of pager in a non-X11 environment and why are there ifdefs?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* KWin loads with the last saved desktop layout
* Changes in KCM are reflected in KWin and pager
Not tested:
* multiple pagers
* vertical pagers</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/pager/pager.h <span style="color: grey">(c482b21)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(1a48194)</span></li>
<li>kwin/kcmkwin/kwindesktop/main.ui <span style="color: grey">(e431d64)</span></li>
<li>kwin/kcmkwin/kwindesktop/main.cpp <span style="color: grey">(ee5c504)</span></li>
<li>plasma/desktop/applets/pager/pager.cpp <span style="color: grey">(588a49d)</span></li>
<li>plasma/desktop/applets/pager/pagerConfig.ui <span style="color: grey">(18fb7c8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102073/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>