<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101728/">http://git.reviewboard.kde.org/r/101728/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 23rd, 2011, 9:24 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">thanks for the patch. i believe it needs some work before it can go in, however.
first off: where is the bug fix, precisely? the patch is large and the bug fix is evidently somewhere in there.
after that, there are some issues i have with the refactor related to stability, speed and code readability.
finally, at most trivially, there remain numerous whitespace issues. this file was already pretty bad, we don't need to make it even more inconsistent, and fully bringing it into line with kdelibs style would be nice.
as for devel policy, doing such things in branches is definitely preferred. due to the size of the plasmate project (small) we do allow/expect people to merge their own branches into master when they are Ready(tm).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you very much for our review:)
I'll try to implement your suggestions.</pre>
<br />
<p>- Etienne</p>
<br />
<p>On June 22nd, 2011, 7:37 p.m., Etienne Rebetez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Etienne Rebetez.</div>
<p style="color: grey;"><i>Updated June 22, 2011, 7:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi,
When trying out plasmate the last day, i was hit with the bug 276082. Since i didn't want that it happens to someone else, i made a fix for it.
I the process i found that the loadTimeLine function was far to big. So i did also some refactoring. (this diff is kinda huge but i made the changes in a branch which i can merge to master)
The timeliene and savepoint creation should now behave as expected.
Let me know what you think.
Etienne
PS: How is the commit policy in plasmate? Could i just push directly to master in the future?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mainwindow.cpp <span style="color: grey">(8326a29)</span></li>
<li>savesystem/timeline.h <span style="color: grey">(719fb73)</span></li>
<li>savesystem/timeline.cpp <span style="color: grey">(d258a1a)</span></li>
<li>savesystem/timelineitem.h <span style="color: grey">(1e9699f)</span></li>
<li>savesystem/timelineitem.cpp <span style="color: grey">(d9b0a67)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101728/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>