<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101430/">http://git.reviewboard.kde.org/r/101430/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 24th, 2011, 8:45 p.m., <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good now. Note that it would be nice to revisit this change when KDE 4.7 is out and string freeze is no longer in effect: either the "<tr>" should be put back in the i18n() call or the "</tr>" should be taken out of the i18n() call. The second option feels better to me, as translators shouldn't have to care about the "tr" (but right-to-left translators need access to the "td")</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From a translators pov please do it properly:
ask on kde-i18n-doc@kde.org for approval to break the string freeze, for sure you'll get that within a few hours for this simple string change.
At leat you'll get my vote for that.
(Comment from the number 1 strings freeze breaker in kde since 3.3 with several ten thousend strings breaks, but of course only with approval from kde-i18n-doc@kde.org)</pre>
<br />
<p>- Burkhard</p>
<br />
<p>On May 24th, 2011, 2:55 p.m., Max Lin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Max Lin.</div>
<p style="color: grey;"><i>Updated May 24, 2011, 2:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After launch krandrtray, move cursor up on krandrtray, it will shows tooltip, however, looks the tag are not match so caused context are not aligned, and text color are not consistent, we also can catch the "tag mismatch" debug message. I added "<tr>" tag to match with "</tr>" tag, after with this patch, the "tag mismatch" message disappear.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine on my openSUSE 11.4 with KDE 4.6.3 , I also attached screenshot before/after with this patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/randr/krandrtray.cpp <span style="color: grey">(aab7295)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101430/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101430/s/172/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/05/24/krandrtray_before_400x100.png" style="border: 1px black solid;" alt="tag mismatch" /></a>
<a href="http://git.reviewboard.kde.org/r/101430/s/173/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/05/24/krandrtray_after_400x100.png" style="border: 1px black solid;" alt="tag match" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>