<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101321/">http://git.reviewboard.kde.org/r/101321/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 9th, 2011, 9:27 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this must not be included in the default bindings set. it must become an extension, just as HTTP and NetworkIO are. i'm not entirely convinced that raw Socket access is needed, though the other half of me can imagine scenarios where it is. ;) in any case, see:
http://techbase.kde.org/Development/Tutorials/Plasma/JavaScript/API#Extensions
also: what are your use cases? and where are the test cases you are using this with?
finally, the methods that represent setters and getters should not be marked as scriptable but instead by exported as Q_PROPERTIES.
i hope the above doesn't sound overly negative, as i'm very happy that there is someone contributing to these bindings. i think this is the first major contribution outside of core plasma hackers :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the review and hints. Will look at it if I have a bit more time again.
My testcase is a Plasma/Applet javascript that connects with some services using telnet. I will try to cleanup and provide a working sample once it's in a better state.
</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On May 9th, 2011, 6:10 p.m., Sebastian Sauer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sebastian Sauer.</div>
<p style="color: grey;"><i>Updated May 9, 2011, 6:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds bindings for QSocket to the Plasma Javascript engine. The idea is to enable low-level access to QSocket to allow dealing with online- and remote-services.
Does there exist a security-/authentification solution this needs to integrate with?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine with my testcases.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/scriptengines/javascript/CMakeLists.txt <span style="color: grey">(1451e16)</span></li>
<li>plasma/scriptengines/javascript/plasmoid/simplejavascriptapplet.cpp <span style="color: grey">(0076cd8)</span></li>
<li>plasma/scriptengines/javascript/simplebindings/socket.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/scriptengines/javascript/simplebindings/socket.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101321/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>